refactor!: close popover without trigger on Esc and outside click #8409
+17
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
approved these changes
Dec 30, 2024
|
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
web-padawan
added a commit
that referenced
this pull request
Feb 10, 2025
) (#8666) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan
added a commit
that referenced
this pull request
Feb 10, 2025
) (#8667) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
|
This ticket/PR has been released with Vaadin 24.7.0.beta1 and is also targeting the upcoming stable 24.7.0 version. |
|
This ticket/PR has been released with Vaadin 24.8.0.alpha1 and is also targeting the upcoming stable 24.8.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8306
Changed the behavior to allow closing on outside click or Esc unless explicitly disabled.
Type of change