refactor: extract chart logic into reusable mixin #8562
+2,688
−2,605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Jan 28, 2025
| import { inflateFunctions } from './helpers.js'; | ||
|
|
||
| /** @private */ | ||
| export function deepMerge(target, source) { |
There was a problem hiding this comment.
We could move this to helpers.js so that we can import it from there also in vaadin-chart-series-mixin.
| @@ -8,9 +8,10 @@ | |||
| * See https://vaadin.com/commercial-license-and-service-terms for the full | |||
| * license. | |||
| */ | |||
| import './vaadin-chart.js'; | |||
There was a problem hiding this comment.
I think there is no need for this import. In vaadin-chart.js we import vaadin-chart-series.js and that should be enough. Previously the import was there only to get global Chart class for instanceof check.
| * See https://vaadin.com/commercial-license-and-service-terms for the full | ||
| * license. | ||
| */ | ||
|
|
There was a problem hiding this comment.
nit: extra newline before import can be removed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted
vaadin-chartlogic into mixin to be reused by the Lit version.Type of change