Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade puppeteer version in yarn.lock to 23.11.1 #8631

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

web-padawan
Copy link
Member

Description

Upgraded puppeteer version to 23.11.1 to verify my finding from #8615 (comment).

Some tests in tooltip-timers.test.js fail since unwanted mouseenter event fires at 0, 0 coordinates.
Especially in packages/tooltip/test/tooltip-timers-lit.generated.test.js. Let's see if this also happens in CI.

Type of change

  • Internal change

@web-padawan
Copy link
Member Author

web-padawan commented Feb 4, 2025

A few other tests (in addition to tooltip timers) failed - note, context-menu in this test also opens on mouseenter:

packages/context-menu/test/items-theme.test.js:

 ❌ items theme > should close the menu and submenu on theme changed
      AssertionError: expected true to be false
      + expected - actual

      -true
      +false
packages/popover/test/timers.test.js:

 ❌ timers > hideDelay > should close the overlay immediately on focusout
      AssertionError: expected true to be false
      + expected - actual

      -true
      +false

Added margin to corresponding target elements in tests to avoid them being rendered at 0, 0 coordinate.
For vaadin-context-menu, the margin is set on the menu itself since listenOn uses this by default.

@web-padawan web-padawan force-pushed the chore/puppeteer-latest branch 3 times, most recently from 0f44b9d to 0c6cc0e Compare February 4, 2025 11:52
@web-padawan web-padawan force-pushed the chore/puppeteer-latest branch from 0c6cc0e to 9d7b663 Compare February 7, 2025 09:21
Copy link

sonarqubecloud bot commented Feb 7, 2025

@web-padawan web-padawan merged commit 5680440 into main Feb 7, 2025
9 checks passed
@web-padawan web-padawan deleted the chore/puppeteer-latest branch February 7, 2025 11:41
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 5680440
error: could not apply 5680440... chore: upgrade puppeteer version in yarn.lock to 23.11.1 (#8631)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants