fix(FormLayout): do not ignore labelsAside when using explicit rows #8760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
fix/form-layout-auto-responsive-labels-aside-with-explicit-torws
branch
2 times, most recently
from
bda868b to
56a691f
Compare
vursen
commented
Mar 4, 2025
vursen
commented
Mar 4, 2025
vursen
force-pushed
the
fix/form-layout-auto-responsive-labels-aside-with-explicit-torws
branch
from
6f273a7 to
3b09faf
Compare
vursen
force-pushed
the
fix/form-layout-auto-responsive-labels-aside-with-explicit-torws
branch
from
3b09faf to
198ec1c
Compare
vursen
force-pushed
the
fix/form-layout-auto-responsive-labels-aside-with-explicit-torws
branch
from
42f9656 to
a6e4bd6
Compare
DiegoCardoso
approved these changes
Mar 4, 2025
|
DiegoCardoso
approved these changes
Mar 4, 2025
vursen
deleted the
fix/form-layout-auto-responsive-labels-aside-with-explicit-torws
branch
vursen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes the issue where
labelsAside=truedidn't apply to form items when they were inside<vaadin-form-row>.Follow-up to #8687
Part of vaadin/platform#7172
Type of change