Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FormLayout): observe DOM changes in form rows #8765

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Mar 5, 2025

Description

The PR fixes the issue where adding / removing fields dynamically to form rows didn't trigger a layout update.

Part of vaadin/platform#7172

Type of change

  • Bugfix

@vursen vursen changed the title fix(FormLayout): observer DOM changes in form rows too fix(FormLayout): observe DOM changes in form rows Mar 5, 2025
@vursen vursen force-pushed the fix/ensure-form-rows-are-observed branch from 75c7436 to f8bc9c1 Compare March 5, 2025 07:30
@vursen vursen requested a review from DiegoCardoso March 5, 2025 11:49
@vursen vursen force-pushed the fix/ensure-form-rows-are-observed branch from f8bc9c1 to e965826 Compare March 5, 2025 11:49
@vursen vursen force-pushed the fix/ensure-form-rows-are-observed branch from e965826 to 9a134cb Compare March 5, 2025 14:35
Copy link

sonarqubecloud bot commented Mar 5, 2025

@vursen vursen merged commit 0efa6a8 into main Mar 5, 2025
9 checks passed
@vursen vursen deleted the fix/ensure-form-rows-are-observed branch March 5, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants