refactor(FormLayout): split layout logic into distinct classes #8770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
vursen
force-pushed
the
extract-responsive-steps-controller
branch
from
a19bc1e to
28b50c8
Compare
1 task
vursen
force-pushed
the
extract-responsive-steps-controller
branch
3 times, most recently
from
d51b5e7 to
22ec06c
Compare
vursen
commented
Mar 7, 2025
| host.style.setProperty('--_max-columns', Math.min(props.maxColumns, maxColumns)); | ||
|
|
||
| host.$.layout.toggleAttribute('fits-labels-aside', this.props.labelsAside && this.__fitsLabelsAside); | ||
| host.$.layout.style.setProperty('--_grid-rendered-column-count', this.__renderedColumnCount); |
There was a problem hiding this comment.
I had to revert to the previous approach that may trigger an extra style recalculation due to reading getComputedStyle after setting CSS properties. Without this, some tests failed – apparently, they were passing before due to a different order of observers, which was actually not efficient.
DiegoCardoso
reviewed
Mar 7, 2025
| * @private | ||
| */ | ||
| export class AbstractLayoutController { | ||
| constructor(host, config) { |
There was a problem hiding this comment.
Would it be beneficial to add a JSdoc type definition here to help with autocomplete?
Something like:
/**
* @typedef {Object} LayoutControllerConfig
* @property {MutationObserverInit} mutationObserverOptions - Options for the MutationObserver.
*/
/**
* @param {HTMLElement} host
* @param {LayoutControllerConfig} config
*/
constructor(host, config) { ... }
web-padawan
reviewed
Mar 7, 2025
packages/form-layout/src/layouts/auto-responsive-layout-controller.js
Outdated
Show resolved
Hide resolved
vursen
force-pushed
the
extract-responsive-steps-controller
branch
from
34bcd95 to
fbb5b1d
Compare
vursen
force-pushed
the
extract-responsive-steps-controller
branch
from
fbb5b1d to
399a2fb
Compare
vursen
changed the title
vursen
force-pushed
the
extract-responsive-steps-controller
branch
from
6b75af6 to
b91c529
Compare
|
DiegoCardoso
approved these changes
Mar 7, 2025
web-padawan
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracts layout logic into distinct classes AutoResponsiveLayout and ResponsiveStepsLayout.
Part of vaadin/platform#7172
Type of change