Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reattach chart after a number of addpoint calls #8776

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ugur-vaadin
Copy link
Contributor

@ugur-vaadin ugur-vaadin commented Mar 8, 2025

Description

This PR makes the chart detach and re-attach momentarily after a fixed number of addPoint calls are made. The threshold is set to 200. This force destroys the configuration and redraws the chart, effectively stopping the listeners piling up. This is a workaround for the underlying HighCharts issue, and should be removed once it is fixed.

Fixes #6383

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/pr
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Copy link

sonarqubecloud bot commented Mar 8, 2025

@ugur-vaadin ugur-vaadin marked this pull request as ready for review March 10, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constant browser memory growth in Vaadin Charts (specifically, type LINE)
1 participant