Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Stream state checks and clean up RamStream ctor usage #229

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

malleoz
Copy link
Contributor

@malleoz malleoz commented Jan 2, 2025

This fixes #228 and fixes #198

@malleoz malleoz force-pushed the ghost-input-eof branch 2 times, most recently from f38c89b to 0355dcf Compare January 2, 2025 01:18
@malleoz malleoz changed the title Refine Stream state checks, prevent input data out-of-bounds reads Refine Stream state checks and clean up RamStream ctor usage Jan 2, 2025
@vabold vabold added the P1 Priority: High label Jan 26, 2025
source/game/kart/KartParamFileManager.cc Outdated Show resolved Hide resolved
source/game/kart/KartParamFileManager.cc Outdated Show resolved Hide resolved
source/game/kart/KartParamFileManager.cc Outdated Show resolved Hide resolved
@malleoz
Copy link
Contributor Author

malleoz commented Jan 26, 2025

Fixed those improvements. Also rebased.

@vabold vabold merged commit d5269d0 into vabold:main Jan 26, 2025
4 checks passed
@malleoz malleoz deleted the ghost-input-eof branch January 26, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desyncs cause Kinoko to crash in replay mode Allow const pointers to be sent into EGG::RamStream
2 participants