-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kinoko API #242
Open
em-eight
wants to merge
18
commits into
vabold:main
Choose a base branch
from
em-eight:api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Kinoko API #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rack/vehicle/character selection besides ghosts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this was brought up lately, and it will be brought up soon again
This PR allows for Kinoko to be used as a library by external programs.
The background is that generally speaking outside programs cannot restrict themselves to mkw's arena-like allocation system, so they cannot link with Kinoko's
operator new
. Without binary patching hacks, this can only be done by making Kinoko a shared library and building it with clang and some special build flags.The majority of the changes are brought by making Kinoko is buildable with clang, which has generally stricter C++ standard conformance. For example:
Besides that I also added some getters to kinoko data that are commonly used externally (used by pynoko).
The difficult thing here is obviously clang. Does kinoko try to switch to clang? Maintain buildability in two compilers? Or just not support API directly. Who knows but for the time being I will be maintaining my fork for anyone who needs it