Skip to content

Add enum parse() compatibility #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
malleoz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add enum parse() compatibility #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion include/Common.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ template <typename T>
concept IntegralType = std::is_integral_v<T>;

template <typename T>
concept ParseableType = std::is_integral_v<T> ||
concept ParseableType = std::is_integral_v<T> || std::is_enum_v<T> ||
(std::is_floating_point_v<T> && (sizeof(T) == 4 || sizeof(T) == 8));

// Form data into integral value
Expand All @@ -416,6 +416,11 @@ template <ParseableType T>
static inline constexpr T parse(T val, std::endian endian = std::endian::big) {
if constexpr (std::is_integral_v<T>) {
return endian == std::endian::native ? val : std::byteswap(val);
} else if constexpr (std::is_enum_v<T>) {
return endian == std::endian::native ?
val :
static_cast<T>(std::byteswap(static_cast<std::underlying_type_t<T>>(val)));

} else {
if constexpr (sizeof(T) == 4) {
return std::bit_cast<T>(parse<u32>(std::bit_cast<u32>(val), endian));
Expand Down