Sync frame 2 #47
Merged
Sync frame 2 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malleoz
commented
Feb 9, 2024
Comment on lines
+103
to
+105
| std::pair<Vector3f, Vector3f> Vector3f::projAndRej(const Vector3f &rhs) { | ||
| return std::pair(proj(rhs), rej(rhs)); | ||
| } |
There was a problem hiding this comment.
We don't need this immediately... We will undoubtedly need it soon, probably for frame 3. Want to keep anyway?
vabold
requested changes
Feb 9, 2024
source/game/kart/KartSub.cc
Outdated
| local_38 = local_38.rej(move()->smoothedUp()); | ||
| } else { | ||
| local_38.x = 0.0f; | ||
| local_38.y = 0.0f; |
There was a problem hiding this comment.
Suggested change
| local_38.y = 0.0f; | |
| local_38.z = 0.0f; |
There was a problem hiding this comment.
We should also consider using a more descriptive name.
vabold
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KartDynamics::m_totalForcewas not being reset at the end ofKartDynamics::calcKartDynamics::m_extVelwas not being modified (effectively reset) inKartSub::calcPass0