Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stage 0 sync #50

Merged
merged 8 commits into from
Mar 14, 2024
Merged

Stage 0 sync #50

merged 8 commits into from
Mar 14, 2024

Conversation

malleoz
Copy link
Contributor

@malleoz malleoz commented Feb 21, 2024 •
edited
Loading

These changes synchronize KartDynamics::m_pos and KartDynamics::m_fullRot until frame 173.

  • Standardizes struct members not using Hungarian notation
  • Corrects inaccurate paired-single functions
  • Standardized getter functions to not use the get prefix

TODO:

  • Determine consistency with array iteration
  • Brainstorm appropriate local variable names for randomly-named variables
    • KCL_TYPE_IDK
  • Resolve discussion around any //TODO comments present
  • Determine if there are any memory leaks from not deleting heap-allocated member variables (Is this out-of-scope?)

malleoz
malleoz commented Feb 21, 2024
View reviewed changes
source/egg/geom/Sphere.cc Show resolved Hide resolved
source/egg/math/Matrix.cc Outdated Show resolved Hide resolved
source/egg/math/Matrix.cc Show resolved Hide resolved
source/egg/math/Vector.cc Show resolved Hide resolved
source/egg/math/Vector.hh Show resolved Hide resolved
source/game/kart/KartCollide.hh Outdated Show resolved Hide resolved
source/game/kart/KartDynamics.cc Show resolved Hide resolved
source/game/kart/KartMove.cc Show resolved Hide resolved
source/game/kart/KartMove.cc Outdated Show resolved Hide resolved
source/game/kart/KartSuspensionPhysics.cc Outdated Show resolved Hide resolved
malleoz
malleoz commented Feb 25, 2024
View reviewed changes
source/game/field/CourseColMgr.cc Outdated Show resolved Hide resolved
source/game/kart/CollisionGroup.cc Outdated Show resolved Hide resolved
source/game/kart/KartBody.cc Show resolved Hide resolved
source/test/TestDirector.cc Outdated Show resolved Hide resolved
source/egg/geom/Sphere.cc Outdated Show resolved Hide resolved
source/egg/math/Quat.cc Outdated Show resolved Hide resolved
malleoz
malleoz commented Feb 28, 2024
View reviewed changes
source/game/kart/KartMove.hh Show resolved Hide resolved
source/game/kart/KartMove.cc Show resolved Hide resolved
vabold
vabold requested changes Mar 6, 2024
View reviewed changes
Copy link
Owner

@vabold vabold left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review was started before a force push, so I have no idea if some of these conversations are already resolved. This covers the first ~20 files or so.

EDIT: I've removed the ones that were already resolved.

source/egg/math/Matrix.cc Outdated Show resolved Hide resolved
source/egg/math/Matrix.cc Outdated Show resolved Hide resolved
source/egg/math/Matrix.cc Outdated Show resolved Hide resolved
source/egg/math/Quat.cc Outdated Show resolved Hide resolved
source/game/field/CourseColMgr.cc Outdated Show resolved Hide resolved
source/game/field/CourseColMgr.cc Outdated Show resolved Hide resolved
source/game/field/CourseColMgr.cc Outdated Show resolved Hide resolved
source/game/field/KColData.cc Outdated Show resolved Hide resolved
source/game/field/KColData.cc Outdated Show resolved Hide resolved
vabold
vabold requested changes Mar 14, 2024
View reviewed changes
source/egg/math/Matrix.cc Outdated Show resolved Hide resolved
source/egg/math/Matrix.cc Outdated Show resolved Hide resolved
source/egg/math/Matrix.cc Outdated Show resolved Hide resolved
source/game/kart/CollisionGroup.cc Outdated Show resolved Hide resolved
source/game/kart/CollisionGroup.cc Outdated Show resolved Hide resolved
source/game/kart/KartSuspensionPhysics.cc Outdated Show resolved Hide resolved
source/game/kart/KartSuspensionPhysics.cc Outdated Show resolved Hide resolved
source/game/kart/KartSuspensionPhysics.cc Outdated Show resolved Hide resolved
source/game/kart/KartSuspensionPhysics.cc Outdated Show resolved Hide resolved
source/game/kart/KartSuspensionPhysics.cc Outdated Show resolved Hide resolved
@vabold vabold merged commit ac6a131 into vabold:main Mar 14, 2024
3 checks passed
vabold pushed a commit that referenced this pull request Mar 14, 2024
@malleoz @vabold
Stage 0 sync (#50)
9e44c1b 
* Complete stage 0 syncing

* Increment stage, cleanup

* Few small changes

* Consistent KColData naming, reorganize KColData header/source func order

* Few small changes again

* New KCL flag, Mathf::abs, clang-format

* Renaming

* Final changes
@malleoz malleoz deleted the frame_3 branch May 11, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ficool2 ficool2 ficool2 left review comments

@vabold vabold vabold requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malleoz @ficool2 @vabold