Clean up KCL collision functions #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to include a small desync that becomes obvious during Mario Circuit's RTA World Record. |
vabold
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now (and by right now I mean in a future PR where we sync rBC), we make use of three sphere collision check functions. They are 95% the same, differing only by certain if-statements based on the TYPE of check performed (at least colliding with an edge, colliding beyond the edge, and colliding while moving towards).
The functions are ugly in Ghidra. Keeping them separate in Kinoko does not make debugging any easier (from a LOT of experience). I will argue that conjoining them here helps readability, as we can distinguish between what types of checks are being performed on a given collision check.