Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing one test case #4

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Fixing one test case #4

merged 2 commits into from
Mar 8, 2024

Conversation

zhaoyuango
Copy link
Contributor

This Pull request adds one assertion to the OzHashSpec test suite for better readability.

@zhaoyuango zhaoyuango requested a review from jjzazuet March 8, 2024 01:34
jjzazuet
jjzazuet requested changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@jjzazuet jjzazuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make a few changes. Thanks!

src/test/java/io/vacco/oruzka/OzHashSpec.java Outdated Show resolved Hide resolved
jjzazuet
jjzazuet approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@jjzazuet jjzazuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@zhaoyuango zhaoyuango merged commit 15eb1ad into develop Mar 8, 2024
1 check failed
@zhaoyuango zhaoyuango deleted the fix/test-fixes branch March 8, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjzazuet jjzazuet jjzazuet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhaoyuango @jjzazuet