Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/3 #5

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Fix/3 #5

merged 4 commits into from
Mar 21, 2024

Conversation

zhaoyuango
Copy link
Contributor

Description

Fix issue #3

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

code was removed and unit tests updated

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warningTest Configuration:
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@zhaoyuango
fix issue #3
ab230dd 
we are removing config utility classes
@zhaoyuango
removing config util classes
c95b300
@zhaoyuango
fix issue #3
c719b10 
we are removing config utility classes
@zhaoyuango zhaoyuango requested a review from jjzazuet March 21, 2024 01:43
@jjzazuet
Copy link
Contributor

Hey @zhaoyuango , did you update the project version number? Thanks!

jjzazuet
jjzazuet requested changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@jjzazuet jjzazuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Please update project version and we should be good. Thanks!

@zhaoyuango
Copy link
Contributor Author

Hey I have updated project version number. thanks

jjzazuet
jjzazuet approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@jjzazuet jjzazuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (looks good to me).

@zhaoyuango zhaoyuango merged commit 3224e0b into develop Mar 21, 2024
1 check failed
@zhaoyuango zhaoyuango deleted the fix/3 branch March 21, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjzazuet jjzazuet jjzazuet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhaoyuango @jjzazuet