Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add gas-report #18

Merged
merged 3 commits into from
Feb 26, 2024
Merged

chore: add gas-report #18

merged 3 commits into from
Feb 26, 2024

Conversation

3esmit
Copy link

@3esmit 3esmit commented Feb 24, 2024

Description

Add script to track gas calls for individual calls on the contracts. Complements gas-snapshot in a more detailed manner.

Fixes #16

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Added natspec comments?
  • Ran forge snapshot?
  • Ran pnpm gas-report?
  • Ran pnpm lint?
  • Ran forge test?
  • Ran pnpm verify?

@3esmit
Copy link
Author

3esmit commented Feb 24, 2024

@0x-r4bbit Do you have any idea why lint is failing?

@3esmit
Copy link
Author

3esmit commented Feb 24, 2024

@0x-r4bbit Do you have any idea why lint is failing?

The damn EOF from Windows was causing this error.

Copy link
Collaborator

@0x-r4bbit 0x-r4bbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you for introducing this!
Just found a tiny mistake we should iron out.

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@0x-r4bbit
Copy link
Collaborator

Also, we should not forget to close #16 when this one here lands

@0x-r4bbit 0x-r4bbit merged commit b711485 into main Feb 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add gas estimate to template
2 participants