feat: add DeploymentConfig for network specifc deployments
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
force-pushed
the
feat/add-deployment-config
branch
from
4deccd1
to
5eb149d
Compare
To allow deployment to different chains but using the same deployment scripts, this commit introduces a basic `DeploymentConfig` which can be extended as necessary in each project. There's a few things that should be considered: - `activeNetworkConfig` will be initialized via the constructor, at which point it is know what `block.chainid` is - To add new configuration settings, extend `NetworkConfig` - To add a new config for a different chain, extend the `if/else` block in the constructor so that it creates a `NetworkConfig` for the chain in question
0x-r4bbit
force-pushed
the
feat/add-deployment-config
branch
from
5eb149d
to
d6bbd46
Compare
|
@rymnc take another look :D |
rymnc
approved these changes
Sep 6, 2023
|
|
||
| contract Deploy is BaseScript { | ||
| function run() public broadcast returns (Foo foo) { | ||
| function run() public returns (Foo foo, DeploymentConfig deploymentConfig) { |
There was a problem hiding this comment.
nice, last question - what does the broadcast keyword specify?
There was a problem hiding this comment.
broadcast is a modifier that wraps the function in vm.startBroadcast() and vm.stopBroadcast().
Anything that happens inside these are tx that are broadcast to the network.
We don't want the instantiation of DeploymentConfig() to happen onchain, we only need it to access our configuration values.
That's why I'm removing the broadcast from the main deploy script's run() function. This gives us control over which action should indeed be broadcast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To allow deployment to different chains but using the same deployment scripts, this commit introduces a basic
DeploymentConfigwhich can be extended as necessary in each project.There's a few things that should be considered:
activeNetworkConfigwill be initialized via the constructor, at which point it is know whatblock.chainidisNetworkConfigif/elseblock in the constructor so that it creates aNetworkConfigfor the chain in questionChecklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm lint?forge test?