Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(connmanager): also show peerID and dir when too many conns #1185

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

Ivansete-status
Copy link
Contributor

@Ivansete-status Ivansete-status commented Aug 30, 2024

Bring a bit more detail when the "Too many connections for peer" message is being logged. Particularly, we are adding the offending peerId and the stream direction

@Ivansete-status Ivansete-status changed the title connmanager.nim: also show peerID and dir when too many conns chore(connmanager): also show peerID and dir when too many conns Aug 30, 2024
@Ivansete-status Ivansete-status self-assigned this Aug 30, 2024
@Ivansete-status Ivansete-status force-pushed the enhance-log-a-little-in-connmanager branch from 9715fda to 5776af2 Compare August 30, 2024 22:41
@diegomrsantos
Copy link
Collaborator

Please add a description explaining why this is necessary. The reason is to prevent people from removing this info in the future if they don't know why it was added.

@Ivansete-status
Copy link
Contributor Author

Please add a description explaining why this is necessary. The reason is to prevent people from removing this info in the future if they don't know why it was added.

Sure! Sorry for the delay in answering. I just added a description now. Thanks!

@diegomrsantos diegomrsantos enabled auto-merge (squash) September 9, 2024 13:04
@diegomrsantos diegomrsantos merged commit 9669965 into master Sep 9, 2024
14 checks passed
@diegomrsantos diegomrsantos deleted the enhance-log-a-little-in-connmanager branch September 9, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

3 participants