Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move mm:refc config and remove skipParentCfg #1190

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Conversation

diegomrsantos
Copy link
Collaborator

@diegomrsantos diegomrsantos commented Sep 8, 2024

  • Moving the mm:refc configuration to the main config.nims file makes it be used in tests and tasks that build examples.
  • It's not clear why skipParentCfgwas being used and it doesn't seem to be necessary.

@diegomrsantos diegomrsantos changed the title chore: move refc config and remove skipParentCfg chore: move mm:refc config and remove skipParentCfg Sep 8, 2024
Copy link
Collaborator

@lchenut lchenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegomrsantos diegomrsantos merged commit 21a4441 into master Sep 10, 2024
14 checks passed
@diegomrsantos diegomrsantos deleted the refc-config branch September 10, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

2 participants