-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update communities spec as per content topic changes #118
Merged
chaitanyaprem
merged 2 commits into
content-topic-usage
from
communities-content-topic-usage
Jan 2, 2025
Merged
update communities spec as per content topic changes #118
chaitanyaprem
merged 2 commits into
content-topic-usage
from
communities-content-topic-usage
Jan 2, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanyaprem
requested review from
D4nte,
jm-clius,
richard-ramos,
plopezlpz,
kaichaosun and
osmaczko
December 17, 2024 12:09
chaitanyaprem
force-pushed
the
communities-content-topic-usage
branch
from
December 17, 2024 12:12
1a972eb
to
a011f09
Compare
chaitanyaprem
changed the title
update spec as per content topic changes
update communities spec as per content topic changes
Dec 17, 2024
jm-clius
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I think that we may need to do a full revision of the spec in future, this makes sense to me in the interim to specify content topic usage. Thanks!
chaitanyaprem
force-pushed
the
content-topic-usage
branch
from
January 2, 2025 11:30
b3ad848
to
cbf5a91
Compare
chaitanyaprem
force-pushed
the
communities-content-topic-usage
branch
from
January 2, 2025 11:32
593583f
to
58d1abf
Compare
Co-authored-by: Hanno Cornelius <68783915+jm-clius@users.noreply.github.com>
chaitanyaprem
force-pushed
the
communities-content-topic-usage
branch
from
January 2, 2025 11:33
58d1abf
to
808845e
Compare
chaitanyaprem
added a commit
that referenced
this pull request
Jan 2, 2025
update communities spec as per content topic changes (#118) - Update content topic usage as per https://forum.vac.dev/t/status-communities-review-and-proposed-usage-of-waku-content-topics/335 - Update symmetric encryption done at content topic level before messages are handed over to waku - Update about shard or pubsub topic usage
chaitanyaprem
added a commit
that referenced
this pull request
Jan 2, 2025
update communities spec as per content topic changes (#118) - Update content topic usage as per https://forum.vac.dev/t/status-communities-review-and-proposed-usage-of-waku-content-topics/335 - Update symmetric encryption done at content topic level before messages are handed over to waku - Update about shard or pubsub topic usage
chaitanyaprem
added a commit
that referenced
this pull request
Jan 2, 2025
1. add usage guidelines for waku content topics 2. update communities spec as per content topic changes (#118) - Update content topic usage as per https://forum.vac.dev/t/status-communities-review-and-proposed-usage-of-waku-content-topics/335 - Update symmetric encryption done at content topic level before messages are handed over to waku - Update about shard or pubsub topic usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- [ ] update communities flows as per current understandingAnything else that can be added please let me know.
@jm-clius i have tried to brief about community shards in this spec, not sure if that in itself be a separate spec with a ref included here. Please advise.