Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update communities spec as per content topic changes #118

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

chaitanyaprem
Copy link
Contributor

@chaitanyaprem chaitanyaprem commented Dec 17, 2024

Anything else that can be added please let me know.

@jm-clius i have tried to brief about community shards in this spec, not sure if that in itself be a separate spec with a ref included here. Please advise.

@chaitanyaprem chaitanyaprem changed the base branch from main to content-topic-usage December 17, 2024 12:11
@chaitanyaprem chaitanyaprem force-pushed the communities-content-topic-usage branch from 1a972eb to a011f09 Compare December 17, 2024 12:12
@chaitanyaprem chaitanyaprem changed the title update spec as per content topic changes update communities spec as per content topic changes Dec 17, 2024
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think that we may need to do a full revision of the spec in future, this makes sense to me in the interim to specify content topic usage. Thanks!

status/56/communities.md Outdated Show resolved Hide resolved
@chaitanyaprem chaitanyaprem marked this pull request as ready for review January 2, 2025 10:47
@chaitanyaprem chaitanyaprem force-pushed the communities-content-topic-usage branch from 593583f to 58d1abf Compare January 2, 2025 11:32
chaitanyaprem and others added 2 commits January 2, 2025 17:03
Co-authored-by: Hanno Cornelius <68783915+jm-clius@users.noreply.github.com>
@chaitanyaprem chaitanyaprem force-pushed the communities-content-topic-usage branch from 58d1abf to 808845e Compare January 2, 2025 11:33
@chaitanyaprem chaitanyaprem merged commit 5a85dd3 into content-topic-usage Jan 2, 2025
2 checks passed
@chaitanyaprem chaitanyaprem deleted the communities-content-topic-usage branch January 2, 2025 11:46
chaitanyaprem added a commit that referenced this pull request Jan 2, 2025
update communities spec as per content topic changes (#118)

- Update content topic usage as per
https://forum.vac.dev/t/status-communities-review-and-proposed-usage-of-waku-content-topics/335
- Update symmetric encryption done at content topic level before
messages are handed over to waku
- Update about shard or pubsub topic usage
chaitanyaprem added a commit that referenced this pull request Jan 2, 2025
update communities spec as per content topic changes (#118)

- Update content topic usage as per
https://forum.vac.dev/t/status-communities-review-and-proposed-usage-of-waku-content-topics/335
- Update symmetric encryption done at content topic level before
messages are handed over to waku
- Update about shard or pubsub topic usage
chaitanyaprem added a commit that referenced this pull request Jan 2, 2025
1. add usage guidelines for waku content topics
2. update communities spec as per content topic changes (#118)  
    - Update content topic usage as per
    https://forum.vac.dev/t/status-communities-review-and-proposed-usage-of-waku-content-topics/335
    - Update symmetric encryption done at content topic level before
    messages are handed over to waku
    - Update about shard or pubsub topic usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants