refactor(RewardStreamerMP): extract MP and Stake mathematical formula… #109
Conversation
There was a problem hiding this comment.
@3esmit great work!
There are some comments I'd like you and @gravityblast to review.
The overall direction is really good!
| /// @notice The accrue rate period of time over which multiplier points are calculated. | ||
| uint256 public constant ACCRUE_RATE = 12 seconds; | ||
| /// @notice Minimal value to generate 1 multiplier point in the accrue rate period (rounded up). | ||
| uint256 public constant MIN_BALANCE = (((YEAR * 100) - 1) / (MP_APY * ACCRUE_RATE)) + 1; |
There was a problem hiding this comment.
Where does this 100 come from? i It's not the MP_APY
Can we have this live in a constant as well?
There was a problem hiding this comment.
MP_APY stands for "Multiplier Points Annual Percentage Yield". The unit of MP_APY is Token % Per Year, the unit of MIN_BALANCE is Token. In order to convert Token % Per Year to Token, we need to remove the Percentage and Year.
I am unsure if a mathematical artifact should have a constant, otherwise we should call it "CENT", or something like that, and seems to complicate the visualization of the formula
There was a problem hiding this comment.
Okay I see, this makes more sense now.
I still think that the MIN_BALANCE is something we should avoid.
We should rather check if MPs greater > 0 will be generated with the given stake amount and if not, simply not update the lastUpdateTime, so next time we calculate MPs we still calculate from the original last update.
See the comment here: #109 (comment)
0x-r4bbit
force-pushed
the
refactor/abstract-math
branch
from
2e124b4 to
6c9963f
Compare
|
@3esmit to move on with this I've now made the necessary changes myself and squashed your commits into one. |
…s to abstract contracts
3esmit
force-pushed
the
refactor/abstract-math
branch
from
6c9963f to
0544c0e
Compare
…s to abstract contracts
Description
Closes #107
Checklist
Ensure you completed all of the steps below before submitting your pull request:
pnpm adorno?pnpm verify?