fix: improve precision loss when unstaking and add testso #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the calculation for when MPs are reduced globally and for the user that is unstaking. Instead of getting an `amountRatio` first and using that the multiplication, we're now applying the `SCALE_FACTOR` to both, the numerator and denominator to maintain the ratio while increasing precision.
gravityblast
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the calculation for when MPs are reduced globally and for the user that is unstaking.
Instead of getting an
amountRatiofirst and using that the multiplication, we're now applying theSCALE_FACTORto both, the numerator and denominator to maintain the ratio while increasing precision.Checklist
Ensure you completed all of the steps below before submitting your pull request:
pnpm adorno?pnpm verify?