Skip to content

Commit

Permalink
Merge pull request #7 from valantic-CEC-Deutschland-GmbH/feature/spry…
Browse files Browse the repository at this point in the history
…-2561

spry-2561 Change access modifiers to protected for several class prop…
  • Loading branch information
HaukeBST authored Nov 22, 2023
2 parents ca07893 + d46c86c commit 8e29c0e
Showing 1 changed file with 13 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,42 +21,42 @@ class ProductReader
/**
* @var string
*/
private const CATEGORY_ID = 'categoryId';
protected const CATEGORY_ID = 'categoryId';

/**
* @var string
*/
private const CATEGORY = 'category';
protected const CATEGORY = 'category';

/**
* @var string
*/
private const KEY_PRODUCTS_PER_PAGE = 'ipp';
protected const KEY_PRODUCTS_PER_PAGE = 'ipp';

/**
* @var \Spryker\Client\ProductStorage\ProductStorageClientInterface
*/
private ProductStorageClientInterface $productStorageClient;
protected ProductStorageClientInterface $productStorageClient;

/**
* @var \Spryker\Client\Catalog\CatalogClientInterface
*/
private CatalogClientInterface $catalogClient;
protected CatalogClientInterface $catalogClient;

/**
* @var \ValanticSpryker\Zed\ProductFirstSpiritApi\Business\Mapper\ProductFirstSpiritApiBusinessMapperInterface
*/
private ProductFirstSpiritApiBusinessMapperInterface $businessMapper;
protected ProductFirstSpiritApiBusinessMapperInterface $businessMapper;

/**
* @var \ValanticSpryker\Zed\FirstSpiritApi\FirstSpiritApiConfig
*/
private FirstSpiritApiConfig $firstSpiritApiConfig;
protected FirstSpiritApiConfig $firstSpiritApiConfig;

/**
* @var \Spryker\Zed\Locale\Business\LocaleFacadeInterface
*/
private LocaleFacadeInterface $localeFacade;
protected LocaleFacadeInterface $localeFacade;

/**
* @param \Spryker\Client\ProductStorage\ProductStorageClientInterface $productStorageClient
Expand All @@ -72,7 +72,7 @@ public function __construct(
LocaleFacadeInterface $localeFacade,
ProductFirstSpiritApiBusinessMapperInterface $businessMapper,
FirstSpiritApiConfig $firstSpiritApiConfig,
private array $queryDataExpanderPlugins = []
protected array $queryDataExpanderPlugins = []
) {
$this->productStorageClient = $productStorageClient;
$this->catalogClient = $catalogClient;
Expand Down Expand Up @@ -143,7 +143,7 @@ public function getAllProducts(FirstSpiritApiRequestTransfer $apiRequestTransfer
*
* @return string
*/
private function getRequestParameter(array $queryData, string $parameterName): string
protected function getRequestParameter(array $queryData, string $parameterName): string
{
if (array_key_exists($parameterName, $queryData)) {
return $queryData[$parameterName];
Expand All @@ -159,7 +159,7 @@ private function getRequestParameter(array $queryData, string $parameterName): s
*
* @return array
*/
private function replaceOldArrayKeyWithNewArrayKey(array $queryData, string $oldKey, string $newKey): array
protected function replaceOldArrayKeyWithNewArrayKey(array $queryData, string $oldKey, string $newKey): array
{
if (array_key_exists($oldKey, $queryData)) {
$keys = array_keys($queryData);
Expand All @@ -176,7 +176,7 @@ private function replaceOldArrayKeyWithNewArrayKey(array $queryData, string $old
*
* @return string
*/
private function getLocaleFromRequestParameters(array $parameters): string
protected function getLocaleFromRequestParameters(array $parameters): string
{
$currentLocale = $this->localeFacade->getCurrentLocaleName();
if (!isset($parameters[CmsFirstSpiritApiConfig::FIRST_SPIRIT_PAGE_LANGUAGE])) {
Expand Down Expand Up @@ -207,7 +207,7 @@ protected function adjustQueryData($queryData): array
*
* @return array
*/
private function extendQueryData(array $queryData): array
protected function extendQueryData(array $queryData): array
{
foreach ($this->queryDataExpanderPlugins as $queryExpanderPlugin) {
$queryData = $queryExpanderPlugin->expandQueryData($queryData);
Expand Down

0 comments on commit 8e29c0e

Please sign in to comment.