Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: update StatementEntry.Condition to be a map[string]map[sting][]string #410

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

ahmad-ibra
Copy link
Contributor

@ahmad-ibra ahmad-ibra commented Jun 21, 2024

Issue

#409

Description

  • Fixes type definition of the StatementEntry.Condition. Now supports multiple Types, and multiple Keys on each Type
  • Also regenerates out of date chart docs with make frigate
  • Fixes issue in samples configs

@ahmad-ibra ahmad-ibra requested a review from a team as a code owner June 21, 2024 01:10
@ahmad-ibra ahmad-ibra requested a review from TylerGillson June 21, 2024 01:10
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 44 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   67.60%   65.82%   -1.78%     
==========================================
  Files          10       10              
  Lines        1068     1112      +44     
==========================================
+ Hits          722      732      +10     
- Misses        279      313      +34     
  Partials       67       67              
Files Coverage Δ
api/v1alpha1/awsvalidator_types.go 100.00% <100.00%> (ø)
internal/validators/iam/iam_validator.go 79.52% <100.00%> (+0.27%) ⬆️
api/v1alpha1/zz_generated.deepcopy.go 43.77% <0.00%> (-6.45%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0696879...bae8606. Read the comment docs.

@ahmad-ibra ahmad-ibra marked this pull request as draft June 21, 2024 03:06
@ahmad-ibra ahmad-ibra force-pushed the fix/statement-entry-typedef branch from ed83d08 to 8e6bd67 Compare June 21, 2024 15:56
@ahmad-ibra ahmad-ibra force-pushed the fix/statement-entry-typedef branch from 205b9a2 to cda26bc Compare June 21, 2024 17:32
@ahmad-ibra ahmad-ibra marked this pull request as ready for review June 21, 2024 17:51
@TylerGillson TylerGillson changed the title fix: update StatementEntry.Condition to be a map[string]map[sting][]string fix!: update StatementEntry.Condition to be a map[string]map[sting][]string Jun 21, 2024
@ahmad-ibra ahmad-ibra merged commit 49c4b16 into main Jun 21, 2024
6 of 7 checks passed
@ahmad-ibra ahmad-ibra deleted the fix/statement-entry-typedef branch June 21, 2024 17:58
@ahmad-ibra ahmad-ibra changed the title fix!: update StatementEntry.Condition to be a map[string]map[sting][]string fix: update StatementEntry.Condition to be a map[string]map[sting][]string Jun 21, 2024
@ahmad-ibra ahmad-ibra changed the title fix: update StatementEntry.Condition to be a map[string]map[sting][]string fix!: update StatementEntry.Condition to be a map[string]map[sting][]string Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants