Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-scaffold project #539

Merged
merged 8 commits into from
Dec 10, 2024
Merged

chore: re-scaffold project #539

merged 8 commits into from
Dec 10, 2024

Conversation

arturshadnik
Copy link
Member

Issue

#536

Description

This PR re-scaffolds the project using kubebuilder alpha generate. The 2 major changes are:

  • Remove all usage of kube-rbac-proxy and replace with WithAuthenticationAndAuthorization due to kube-rbac-proxy being deprecated
  • Initialize e2e tests. For now, we are only testing basic functionality. The tests should be expanded to cover validator-specific use-cases.

Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
@arturshadnik arturshadnik requested a review from a team as a code owner December 10, 2024 05:49
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement Enhancement to an existing feature labels Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 218 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tests/utils/utils.go 0.00% 159 Missing ⚠️
cmd/main.go 0.00% 59 Missing ⚠️
@@             Coverage Diff             @@
##             main     #539       +/-   ##
===========================================
- Coverage   67.29%   57.21%   -10.08%     
===========================================
  Files          11       12        +1     
  Lines        1226     1442      +216     
===========================================
  Hits          825      825               
- Misses        343      559      +216     
  Partials       58       58               
Files with missing lines Coverage Δ
api/v1alpha1/awsvalidator_types.go 88.00% <ø> (ø)
internal/controller/awsvalidator_controller.go 74.07% <ø> (ø)
pkg/validators/iam/iam_validator.go 79.95% <ø> (ø)
cmd/main.go 0.00% <0.00%> (ø)
tests/utils/utils.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e8b90...660c65d. Read the comment docs.

arturshadnik and others added 4 commits December 10, 2024 09:27
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Dec 10, 2024
arturshadnik and others added 3 commits December 10, 2024 11:26
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
@TylerGillson TylerGillson self-requested a review December 10, 2024 21:25
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 10, 2024
@TylerGillson TylerGillson merged commit a309fdb into main Dec 10, 2024
7 of 8 checks passed
@TylerGillson TylerGillson deleted the chore/re-scaffold branch December 10, 2024 21:35
arturshadnik pushed a commit that referenced this pull request Dec 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.1.11](v0.1.10...v0.1.11)
(2024-12-10)


### Other

* re-scaffold project
([#539](#539))
([a309fdb](a309fdb))


### Dependency Updates

* **deps:** update all non-major dependencies
([#534](#534))
([c13ebf3](c13ebf3))
* **deps:** update build digest to c847351
([#538](#538))
([c00790d](c00790d))
* **deps:** update build digest to de3e944
([#537](#537))
([4af93aa](4af93aa))
* **deps:** update golang.org/x/exp digest to 43b7b7c
([#535](#535))
([9d7140e](9d7140e))
* **deps:** update module github.com/validator-labs/validator to v0.1.14
([#532](#532))
([96b6a48](96b6a48))
* **deps:** update module sigs.k8s.io/cluster-api to v1.8.6
([#540](#540))
([6706ae8](6706ae8))
* **deps:** update module sigs.k8s.io/cluster-api to v1.9.0
([#541](#541))
([41e8b90](41e8b90))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants