Skip to content

chore: add hook to install validator crds in devspace #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

ahmad-ibra
Copy link
Member

Description

Quality of life improvement. Handles installing the validator crds for us when using devspace.

@ahmad-ibra ahmad-ibra requested a review from a team as a code owner August 1, 2024 22:38
@ahmad-ibra ahmad-ibra requested a review from mattwelke August 1, 2024 22:38
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 1, 2024
@ahmad-ibra ahmad-ibra force-pushed the chore/devspace-crd-hook branch from b3bdb32 to 1ccb453 Compare August 1, 2024 22:38
@dosubot dosubot bot added the enhancement Enhancement to an existing feature label Aug 1, 2024
@ahmad-ibra ahmad-ibra force-pushed the chore/devspace-crd-hook branch from 1ccb453 to 44af5b9 Compare August 1, 2024 22:39
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   61.38%   66.48%   +5.10%     
==========================================
  Files          10        9       -1     
  Lines         681      561     -120     
==========================================
- Hits          418      373      -45     
+ Misses        245      175      -70     
+ Partials       18       13       -5     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be40010...d4a3450. Read the comment docs.

@ahmad-ibra ahmad-ibra merged commit 8982a0d into main Aug 1, 2024
8 checks passed
@ahmad-ibra ahmad-ibra deleted the chore/devspace-crd-hook branch August 1, 2024 22:49
TylerGillson added a commit that referenced this pull request Aug 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.0.15](v0.0.14...v0.0.15)
(2024-08-06)


### Other

* add hook to install validator crds in devspace
([#221](#221))
([8982a0d](8982a0d))
* remove unused helm value
([#223](#223))
([1651b8e](1651b8e))


### Docs

* principal ID and rules in readme
([#222](#222))
([db29a62](db29a62))


### Dependency Updates

* **deps:** update module github.com/onsi/gomega to v1.34.1
([#217](#217))
([4c5d239](4c5d239))
* **deps:** update module github.com/validator-labs/validator to v0.0.51
([#216](#216))
([be40010](be40010))
* **deps:** update module github.com/validator-labs/validator to v0.1.0
([#220](#220))
([57205c6](57205c6))


### Refactoring

* return error from validate, accept context
([#226](#226))
([58989c0](58989c0))
* support direct rule evaluation
([#225](#225))
([bec4a0b](bec4a0b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants