-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: support direct rule evaluation #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #239 +/- ##
==========================================
- Coverage 40.93% 39.63% -1.31%
==========================================
Files 6 7 +1
Lines 386 381 -5
==========================================
- Hits 158 151 -7
- Misses 215 216 +1
- Partials 13 14 +1
Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
TylerGillson
added a commit
to validator-labs/validator-plugin-aws
that referenced
this pull request
Aug 5, 2024
## Issue N/S ## Description Refactor to support direct, in-process evaluation of AWS rules. Required by: - validator-labs/validatorctl#102 Related: - validator-labs/validator-plugin-network#239 --------- Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
TylerGillson
added a commit
that referenced
this pull request
Aug 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.22](v0.0.21...v0.0.22) (2024-08-05) ### Refactoring * support direct rule evaluation ([#239](#239)) ([c195bba](c195bba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Enhancement to an existing feature
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description
Refactor to support direct, in-process evaluation of network rules.
Required by:
validator check --direct
validatorctl#102Related: