Skip to content

refactor: support direct rule evaluation #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 5, 2024

Conversation

TylerGillson
Copy link
Member

@TylerGillson TylerGillson commented Aug 3, 2024

Issue

N/A

Description

Refactor to support direct, in-process evaluation of network rules.

Required by:

Related:

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson requested a review from a team as a code owner August 3, 2024 17:30
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement Enhancement to an existing feature labels Aug 3, 2024
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 66.15385% with 22 lines in your changes missing coverage. Please review.

Files Patch % Lines
pkg/network/network.go 30.76% 9 Missing ⚠️
pkg/validate/validate.go 79.31% 5 Missing and 1 partial ⚠️
internal/controller/networkvalidator_controller.go 50.00% 3 Missing and 2 partials ⚠️
api/v1alpha1/networkvalidator_types.go 84.61% 1 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   40.93%   39.63%   -1.31%     
==========================================
  Files           6        7       +1     
  Lines         386      381       -5     
==========================================
- Hits          158      151       -7     
- Misses        215      216       +1     
- Partials       13       14       +1     
Files Coverage Δ
pkg/http/http.go 81.48% <ø> (ø)
pkg/secrets/secrets.go 100.00% <ø> (ø)
api/v1alpha1/networkvalidator_types.go 80.64% <84.61%> (+0.64%) ⬆️
internal/controller/networkvalidator_controller.go 46.00% <50.00%> (-19.27%) ⬇️
pkg/validate/validate.go 79.31% <79.31%> (ø)
pkg/network/network.go 23.40% <30.76%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c280e89...36f7564. Read the comment docs.

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
TylerGillson added a commit to validator-labs/validator-plugin-aws that referenced this pull request Aug 5, 2024
## Issue
N/S

## Description
Refactor to support direct, in-process evaluation of AWS rules.

Required by:
- validator-labs/validatorctl#102

Related:
- validator-labs/validator-plugin-network#239

---------

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson merged commit c195bba into main Aug 5, 2024
8 checks passed
@TylerGillson TylerGillson deleted the refactor/direct-evaluation branch August 5, 2024 22:07
TylerGillson added a commit that referenced this pull request Aug 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.0.22](v0.0.21...v0.0.22)
(2024-08-05)

### Refactoring

* support direct rule evaluation
([#239](#239))
([c195bba](c195bba))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant