Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: re-scaffold project #301

Merged
merged 4 commits into from
Dec 10, 2024
Merged

chore: re-scaffold project #301

merged 4 commits into from
Dec 10, 2024

Conversation

arturshadnik
Copy link
Member

Issue

#297

Description

This PR re-scaffolds the project using kubebuilder alpha generate. The 2 major changes are:

  • Remove all usage of kube-rbac-proxy and replace with WithAuthenticationAndAuthorization due to kube-rbac-proxy being deprecated
  • Initialize e2e tests. For now, we are only testing basic functionality. The tests should be expanded to cover validator-specific use-cases.

@arturshadnik arturshadnik requested a review from a team as a code owner December 10, 2024 04:54
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement Enhancement to an existing feature labels Dec 10, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 218 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tests/utils/utils.go 0.00% 159 Missing ⚠️
cmd/main.go 0.00% 59 Missing ⚠️ 
@@             Coverage Diff             @@
##             main     #301       +/-   ##
===========================================
- Coverage   34.18%   24.00%   -10.19%     
===========================================
  Files           7        8        +1     
  Lines         509      725      +216     
===========================================
  Hits          174      174               
- Misses        322      538      +216     
  Partials       13       13
Files with missing lines Coverage Δ
api/v1alpha1/networkvalidator_types.go 25.00% <ø> (ø)
internal/controller/networkvalidator_controller.go 44.77% <ø> (ø)
cmd/main.go 0.00% <0.00%> (ø)
tests/utils/utils.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e32e35...2c0920d. Read the comment docs.

@arturshadnik @mattwelke
chore: re-scaffold project
8abb4df 
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
mattwelke
mattwelke reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@mattwelke mattwelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. Just pointed out one thing though.

config/manager/kustomization.yaml Outdated Show resolved Hide resolved
arturshadnik and others added 3 commits December 10, 2024 09:39
@arturshadnik
fix: add validator scheme back to init
a7b91c9 
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
@arturshadnik
Merge branch 'main' into chore/re-scaffold
416f8bc
@arturshadnik
chore: remove devcontainer, add comment about metrics cert
2c0920d 
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Dec 10, 2024
@TylerGillson TylerGillson merged commit e4f6449 into main Dec 10, 2024
7 of 8 checks passed
@TylerGillson TylerGillson deleted the chore/re-scaffold branch December 10, 2024 21:35
@TylerGillson TylerGillson mentioned this pull request Dec 10, 2024
Merged
arturshadnik pushed a commit that referenced this pull request Dec 11, 2024
@TylerGillson
chore(main): release 0.1.1 (#272)
7670e0e 
🤖 I have created a release *beep* *boop*
---


##
[0.1.1](v0.1.0...v0.1.1)
(2024-12-10)


### Other

* make reviewable
([#277](#277))
([a5b7c21](a5b7c21))
* make reviewable
([#280](#280))
([7220e79](7220e79))
* re-scaffold project
([#301](#301))
([e4f6449](e4f6449))
* update renovate.json
([523cc9d](523cc9d))
* Update renovate.json
([33066e1](33066e1))


### Dependency Updates

* **deps:** update all non-major dependencies
([#283](#283))
([0119b0c](0119b0c))
* **deps:** update all non-major dependencies
([#288](#288))
([56d9ce0](56d9ce0))
* **deps:** update build digest to 3463b98
([#285](#285))
([ea679f9](ea679f9))
* **deps:** update build digest to 3840c9d
([#286](#286))
([f540d4e](f540d4e))
* **deps:** update build digest to 5ffe724
([#287](#287))
([b265864](b265864))
* **deps:** update build digest to a46a554
([#291](#291))
([b0d6190](b0d6190))
* **deps:** update build digest to c847351
([#300](#300))
([72f6111](72f6111))
* **deps:** update build digest to d0ef938
([#295](#295))
([4fb60d3](4fb60d3))
* **deps:** update build digest to db64f63
([#284](#284))
([228dc55](228dc55))
* **deps:** update build digest to dd09b58
([#290](#290))
([558ba95](558ba95))
* **deps:** update build digest to de3e944
([#299](#299))
([0a68f3c](0a68f3c))
* **deps:** update golang docker tag to v1.23
([#251](#251))
([729b5e0](729b5e0))
* **deps:** update kubernetes packages to v0.31.1
([#276](#276))
([5134164](5134164))
* **deps:** update kubernetes packages to v0.31.2
([#278](#278))
([946f0c1](946f0c1))
* **deps:** update module github.com/onsi/ginkgo/v2 to v2.21.0
([#281](#281))
([8807b70](8807b70))
* **deps:** update module github.com/onsi/gomega to v1.35.0
([#282](#282))
([ee3eee1](ee3eee1))
* **deps:** update module github.com/onsi/gomega to v1.36.0
([#294](#294))
([a9ee57a](a9ee57a))
* **deps:** update module github.com/onsi/gomega to v1.36.1
([#302](#302))
([5c118e0](5c118e0))
* **deps:** update module github.com/stretchr/testify to v1.10.0
([#293](#293))
([5a7fd65](5a7fd65))
* **deps:** update module github.com/validator-labs/validator to v0.1.10
([#271](#271))
([0d7b185](0d7b185))
* **deps:** update module github.com/validator-labs/validator to v0.1.12
([#274](#274))
([3fc50bf](3fc50bf))
* **deps:** update module github.com/validator-labs/validator to v0.1.13
([#292](#292))
([f5cfc99](f5cfc99))
* **deps:** update module github.com/validator-labs/validator to v0.1.14
([#296](#296))
([8302013](8302013))
* **deps:** update module sigs.k8s.io/cluster-api to v1.8.2
([#273](#273))
([3cda3f3](3cda3f3))
* **deps:** update module sigs.k8s.io/cluster-api to v1.8.4
([#275](#275))
([b8edc07](b8edc07))
* **deps:** update module sigs.k8s.io/cluster-api to v1.9.0
([#303](#303))
([9e32e35](9e32e35))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.19.1
([#279](#279))
([a75dfd9](a75dfd9))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.19.2
([#289](#289))
([f842495](f842495))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.19.3
([#298](#298))
([617ae81](617ae81))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerGillson TylerGillson TylerGillson left review comments

@mattwelke mattwelke mattwelke left review comments

Assignees
No one assigned
Labels
enhancement Enhancement to an existing feature size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arturshadnik @TylerGillson @mattwelke