Skip to content

Conversation

mkmkme
Copy link
Collaborator

@mkmkme mkmkme commented Sep 23, 2025

Pull Request check-list

Make mypy slightly happier by fixing some typing in socket.py

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

Signed-off-by: Mikhail Koviazin <github@mkmk.aleeas.com>
@mkmkme mkmkme force-pushed the mkmkme/socket-fix-typing branch from 41e371b to 79c0e19 Compare September 23, 2025 22:00
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.80%. Comparing base (f991654) to head (79c0e19).

Files with missing lines Patch % Lines
valkey/_parsers/socket.py 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   76.30%   73.80%   -2.51%     
==========================================
  Files         130      130              
  Lines       33954    33958       +4     
==========================================
- Hits        25909    25062     -847     
- Misses       8045     8896     +851     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkmkme
Copy link
Collaborator Author

mkmkme commented Sep 23, 2025

Okay apparently None is a valid value here that we'd like to pass, this is causing tests to fail.
In order to make mypy happier, I'll need TypeGuard that is introduced in 3.10, so I'll wait until #220 is merged.

@mkmkme mkmkme marked this pull request as draft September 23, 2025 22:50
@mkmkme mkmkme added the blocked label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants