Rewrite transaction code, to make it easier to move to client

[adam-fowler]

No description provided.

[github-actions]

❌ Benchmark comparison failed with error ❌

Summary

==============================================================================
Threshold deviations for ValkeyBenchmarks:Connection: Pipeline array benchmark
==============================================================================

Malloc (total) (K, %)	main	pull_request	Difference %	Threshold %
p25	37	33	-10	5
p50	37	34	-9	5
p75	38	34	-9	5

========================================================================
Threshold deviations for ValkeyBenchmarks:Connection: Pipeline benchmark
========================================================================

Malloc (total) (K, %)	main	pull_request	Difference %	Threshold %
p25	36	33	-10	5
p50	37	33	-10	5
p75	37	34	-9	5

New baseline 'pull_request' is BETTER than the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host '4e8ecd7df5c5' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

ValkeyBenchmarks

Client: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	83	83	86	89	89	89	89	6
pull_request	83	84	85	87	88	88	88	6
Δ	0	1	-1	-2	-1	-1	-1	0
Improvement %	0	-1	1	2	1	1	1	0

Client: GET benchmark | parallel 20 | 20 concurrent connections metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	95	99	101	106	111	111	111	24
pull_request	97	99	103	106	109	112	112	24
Δ	2	0	2	0	-2	1	1	0
Improvement %	-2	0	-2	0	2	-1	-1	0

Connection: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	4	4	4	4	4	4	4	8
pull_request	4	4	4	4	4	4	4	8
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: GET benchmark – NoOpTracer metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	7	8	8	10	10	10	10	8
pull_request	7	8	8	10	10	10	10	8
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: Pipeline array benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	37	37	37	38	43	43	43	4
pull_request	33	33	34	34	34	34	34	6
Δ	-4	-4	-3	-4	-9	-9	-9	2
Improvement %	11	11	8	11	21	21	21	2

Connection: Pipeline benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	36	36	37	37	37	37	37	4
pull_request	33	33	33	34	34	34	34	5
Δ	-3	-3	-4	-3	-3	-3	-3	1
Improvement %	8	8	11	8	8	8	8	1

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	17
pull_request	0	0	0	0	0	0	0	18
Δ	0	0	0	0	0	0	0	1
Improvement %	0	0	0	0	0	0	0	1

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	736
pull_request	0	0	0	0	0	0	0	744
Δ	0	0	0	0	0	0	0	8
Improvement %	0	0	0	0	0	0	0	8

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	1904
pull_request	0	0	0	0	0	0	0	1870
Δ	0	0	0	0	0	0	0	-34
Improvement %	0	0	0	0	0	0	0	-34

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	360
pull_request	0	0	0	0	0	0	0	360
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0