Skip to content

Conversation

@dmitrypol
Copy link
Contributor

@dmitrypol dmitrypol commented Nov 2, 2025

Signed-off-by: Dmitry Polyakovsky <dmitry.polyakovky@oracle.com>
@dmitrypol dmitrypol force-pushed the valkey7.2-fix-modules-examples branch from 3904192 to 0aa1c4e Compare November 2, 2025 19:35
@rjd15372
Copy link
Member

rjd15372 commented Nov 3, 2025

Hi @dmitrypol, can you add a description to the PR explaining why this change is needed in 7.2 branch? Is this a simple backport of #342 ?

@dmitrypol
Copy link
Contributor Author

@rjd15372 - do you have any experience with these CI failures? I am able to run all tests locally

@roshkhatri
Copy link
Member

I looked into the notification job failure, looks like we have not backported the change here: #815

on 7.2 branch the job trigger looks like this:

notify-about-job-results:
    runs-on: ubuntu-latest
    if: always() && github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey'

but we need it to be like

if: always() && github.event_name == 'schedule' && github.repository == 'valkey-io/valkey'

Dmitry Polyakovsky added 2 commits November 5, 2025 16:18
Signed-off-by: Dmitry Polyakovsky <dmitry.polyakovky@oracle.com>
Signed-off-by: Dmitry Polyakovsky <dmitry.polyakovky@oracle.com>
@dmitrypol
Copy link
Contributor Author

thank you @roshkhatri . Backported the change for CI, hopefully this fixes the build

Signed-off-by: Dmitry Polyakovsky <dmitry.polyakovky@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants