replace strcmp with byte-by-byte comparison in aof #2809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murad shahmammadli <shmurad@amazon.com>
Contributor
|
Do you mean #2792 in the PR description? |
Author
|
Oops, yeah. I updated the description. |
JimB123
approved these changes
Nov 14, 2025
JimB123
approved these changes
Nov 14, 2025
Member
JimB123
left a comment
JimB123
left a comment
There was a problem hiding this comment.
LGTM - but see comment on the issue: #2792 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2792
Replace strcmp with byte-by-byte comparison to avoid accidental heap-buffer-overflow errors.