Refactor of LFU/LRU code for modularity #2857
Open
+295
−217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General cleanup on LRU/LFU code. Improve modularity and maintainability.
Specifically:
lrulfu.c, with an API inlrulfu.h. Knowledge of the LRU/LFU implementation was previously spread out acrossdb.c,evict.c,object.c,server.c, andserver.h.lrulfu.cknows about the LRU/LFU algorithms, without knowing about therobj.object.cknows about therobjwithout knowing about the details of the LRU/LFU algorithms.server.lruclock, instead usingserver.unixtime. This also eliminates the periodic need to callmstime()to maintain the lru clock.LFUTimeElapsedfunction (off by 1 after rollover).debug.cwhich would perform LFU modification on an LRU value.