Skip to content

Conversation

@ranshid
Copy link
Member

@ranshid ranshid commented Nov 26, 2025

When we added the Hash Field Expiration feature in Valkey 9.0, some of the new command docs included complexity description of O(1) even tough they except multiple arguments.
(see discussion in #2851 (comment))
This PR does:

  1. align all the commands to the same description
  2. fix the complexity description of some commands (eg HSETEX and HGETEX)

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
@ranshid ranshid moved this to In Progress in Valkey 9.1 Nov 26, 2025
@ranshid ranshid moved this to To be backported in Valkey 9.0 Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.38%. Comparing base (da3c43d) to head (0806a56).
⚠️ Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2875      +/-   ##
============================================
- Coverage     72.43%   72.38%   -0.05%     
============================================
  Files           128      128              
  Lines         70439    70439              
============================================
- Hits          51022    50987      -35     
- Misses        19417    19452      +35     
Files with missing lines Coverage Δ
src/commands.def 100.00% <ø> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
@ranshid ranshid merged commit 9562bdc into valkey-io:unstable Nov 26, 2025
56 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Valkey 9.1 Nov 26, 2025
ranshid added a commit to ranshid/valkey that referenced this pull request Nov 26, 2025
valkey-io#2875)

When we added the Hash Field Expiration feature in Valkey 9.0, some of
the new command docs included complexity description of O(1) even tough
they except multiple arguments.
(see discussion in
valkey-io#2851 (comment))
This PR does:
1. align all the commands to the same description
2. fix the complexity description of some commands (eg HSETEX and
HGETEX)

---------

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
zhijun42 pushed a commit to zhijun42/valkey that referenced this pull request Nov 28, 2025
valkey-io#2875)

When we added the Hash Field Expiration feature in Valkey 9.0, some of
the new command docs included complexity description of O(1) even tough
they except multiple arguments.
(see discussion in
valkey-io#2851 (comment))
This PR does:
1. align all the commands to the same description
2. fix the complexity description of some commands (eg HSETEX and
HGETEX)

---------

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
zhijun42 pushed a commit to zhijun42/valkey that referenced this pull request Nov 28, 2025
valkey-io#2875)

When we added the Hash Field Expiration feature in Valkey 9.0, some of
the new command docs included complexity description of O(1) even tough
they except multiple arguments.
(see discussion in
valkey-io#2851 (comment))
This PR does:
1. align all the commands to the same description
2. fix the complexity description of some commands (eg HSETEX and
HGETEX)

---------

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
zhijun42 pushed a commit to zhijun42/valkey that referenced this pull request Nov 28, 2025
valkey-io#2875)

When we added the Hash Field Expiration feature in Valkey 9.0, some of
the new command docs included complexity description of O(1) even tough
they except multiple arguments.
(see discussion in
valkey-io#2851 (comment))
This PR does:
1. align all the commands to the same description
2. fix the complexity description of some commands (eg HSETEX and
HGETEX)

---------

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To be backported
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants