Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the release flow #2298

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix the release flow #2298

merged 2 commits into from
Jan 30, 2025

Conversation

Adamantios
Copy link
Collaborator

Proposed changes

This PR fixes a typo in the release flow that caused the specified Python version to be ignored, resulting in the default version being used instead.

As a result, failures occurred because the project's Pipfile expects Python 3.10 to be present in the system.

With this fix, the correct Python version will be properly recognized, ensuring the release flow runs as expected.

Fixes

n/a

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

n/a

The default python version was being applied instead, because of the typo.
@Adamantios Adamantios merged commit c9fd6f7 into main Jan 30, 2025
10 checks passed
@Adamantios Adamantios deleted the fix/release-flow branch January 30, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants