This repository was archived by the owner on Nov 10, 2022. It is now read-only.
mock_bot rewritten to pass tests with Eventmachine backend#14
Open
ericgj wants to merge 8 commits intovangberg:masterfrom
Open
mock_bot rewritten to pass tests with Eventmachine backend#14ericgj wants to merge 8 commits intovangberg:masterfrom
ericgj wants to merge 8 commits intovangberg:masterfrom
Conversation
…ct) event; move tests to test_autojoin
Author
|
PS. the commit to pull from is a44fda2. The further commits listed above are for features I've started to add to my fork - namely, ability to configure bots from external file; and ability to auto-join channels. If you like I can submit pull requests for these feature branches separately (I've added tests for them and they all pass). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I redesigned mock_bot to work with Eventmachine, so the tests pass, with minimal changes. See what you think.
Thanks for a great little tool and excellent code BTW - learned a lot reading it.