Fix slow file traversal in configuration phase (#163)

Replace .files with .getFrom() for ConfigurableFileCollection objectsFiles list all folder content that could be extermely slow for the second build
vanniktech · Sep 27, 2019 · 5461b09 · 5461b09
1 parent 9607c93
commit 5461b09
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/main/groovy/com/vanniktech/android/junit/jacoco/GenerationPlugin.groovy b/src/main/groovy/com/vanniktech/android/junit/jacoco/GenerationPlugin.groovy
@@ -89,9 +89,9 @@ class GenerationPlugin implements Plugin<Project> {
                 mergeTask.executionData.setFrom(executionData.files + mergeTask.executionData.files)
             }
             if (mergedReportTask != null) {
-                mergedReportTask.classDirectories.setFrom(classDirectories.files + mergedReportTask.classDirectories.files)
-                mergedReportTask.additionalSourceDirs.setFrom(additionalSourceDirs.files + mergedReportTask.additionalSourceDirs.files)
-                mergedReportTask.sourceDirectories.setFrom(sourceDirectories.files + mergedReportTask.sourceDirectories.files)
+                mergedReportTask.classDirectories.setFrom(classDirectories.getFrom() + mergedReportTask.classDirectories.getFrom())
+                mergedReportTask.additionalSourceDirs.setFrom(additionalSourceDirs.getFrom() + mergedReportTask.additionalSourceDirs.getFrom())
+                mergedReportTask.sourceDirectories.setFrom(sourceDirectories.getFrom() + mergedReportTask.sourceDirectories.getFrom())
             }
         }
 
@@ -248,9 +248,9 @@ class GenerationPlugin implements Plugin<Project> {
                 mergeTask.executionData.setFrom(executionData.files + mergeTask.executionData.files)
             }
             if (mergedReportTask != null && addToMergeTask) {
-                mergedReportTask.classDirectories.setFrom(classDirectories.files + mergedReportTask.classDirectories.files)
-                mergedReportTask.additionalSourceDirs.setFrom(additionalSourceDirs.files + mergedReportTask.additionalSourceDirs.files)
-                mergedReportTask.sourceDirectories.setFrom(sourceDirectories.files + mergedReportTask.sourceDirectories.files)
+              mergedReportTask.classDirectories.setFrom(classDirectories.getFrom() + mergedReportTask.classDirectories.getFrom())
+              mergedReportTask.additionalSourceDirs.setFrom(additionalSourceDirs.getFrom() + mergedReportTask.additionalSourceDirs.getFrom())
+              mergedReportTask.sourceDirectories.setFrom(sourceDirectories.getFrom() + mergedReportTask.sourceDirectories.getFrom())
             }
         }