Fix duplicated tree links in Gradle 8.10 #258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly I'm not sure exactly what causes my issue, but when I bumped my project up from Gradle 8.9 to 8.10 I started getting duplicated links in my project dependency tree. So it would generate a dotfile something like:
when before it would only have one instance of each module link. The duplication would happen at seemingly random frequencies, but it was repeatable for the same module links.
This PR squashes the issue by forcing uniqueness of the pair of "from" and "to" nodes on the
ProjectDependencyContainer
class. All tests pass okay and the dotfile comes out okay on my machine, but I'd be interested to see whether anyone else sees something similar.Also added local.properties to gitignore, hopefully this isn't an issue