Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated tree links in Gradle 8.10 #258

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix duplicated tree links in Gradle 8.10 #258

merged 1 commit into from
Aug 20, 2024

Conversation

jonapoul
Copy link
Contributor

@jonapoul jonapoul commented Aug 19, 2024

Honestly I'm not sure exactly what causes my issue, but when I bumped my project up from Gradle 8.9 to 8.10 I started getting duplicated links in my project dependency tree. So it would generate a dotfile something like:

digraph {
...

":a"
":b"
":c"
":d"

":a" -> ":b"
":a" -> ":b"
":a" -> ":b"
":a" -> ":c"
":a" -> ":c"
":b" -> ":d"
}

when before it would only have one instance of each module link. The duplication would happen at seemingly random frequencies, but it was repeatable for the same module links.

This PR squashes the issue by forcing uniqueness of the pair of "from" and "to" nodes on the ProjectDependencyContainer class. All tests pass okay and the dotfile comes out okay on my machine, but I'd be interested to see whether anyone else sees something similar.

Also added local.properties to gitignore, hopefully this isn't an issue

@vanniktech vanniktech merged commit 35a8d61 into vanniktech:master Aug 20, 2024
1 check passed
@vanniktech
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants