Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add color_transfer in video and count streams #53

Closed
wants to merge 1 commit into from

Conversation

sapsan4eg
Copy link

No description provided.

@vansante
Copy link
Owner

vansante commented Nov 4, 2024

Adding the ColorTransfer field is fine by me 👍 .

I am however not sure all that extra counting code is worth the effort when you can just do:

// Assume this is the returned data from the command
var p *ProbeData

// to count all video streams:
count := len(p.StreamType(ffprobe.StreamVideo))

You could argue that your counting code is more performant, because it does not allocate a new slice, but I expect the number of streams to be < 10 in most common cases.

probedata.go Outdated Show resolved Hide resolved
@vansante
Copy link
Owner

You might want to rebase on v2 to fix the CI ;)

@vansante
Copy link
Owner

Has been added by #54

@vansante vansante closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants