Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 7 #13

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Chapter 7 #13

merged 5 commits into from
Jun 4, 2024

Conversation

bartvanb
Copy link
Member

Rough first version of algorithm development lesson

Copy link

github-actions bot commented Apr 17, 2024

NOTE: This Pull Request (#13) was previously merged

github-actions bot pushed a commit that referenced this pull request Apr 17, 2024
@bartvanb bartvanb requested a review from dsmits April 21, 2024 07:30
github-actions bot pushed a commit that referenced this pull request Apr 21, 2024
@dsmits
Copy link
Member

dsmits commented Apr 24, 2024

Nice work!

Although it would be nice if there is a little bit more explanation on what exactly is happening. Like, what is a partial function? How/where will the algorithm be executed? You are covering the tooling, but could you sprinkle in a bit more knowledge about the underlying fundamentals? Maybe with a diagram? A shitty hand-drawn diagram would be ok for now.

@dsmits dsmits marked this pull request as ready for review April 24, 2024 07:33
@dsmits dsmits marked this pull request as draft April 24, 2024 07:33
@bartvanb
Copy link
Member Author

Hi @dsmits , good point! I think the amount of detail that I should provide in background depends on Episode 3 (#5) where algorithms are introduced for non-programmers. So I'll wait for that and adjust accordingly

@bartvanb bartvanb changed the title Episode/developing algorithms Chapter 7 Jun 4, 2024
@bartvanb bartvanb marked this pull request as ready for review June 4, 2024 06:49
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
@dsmits dsmits force-pushed the episode/developing-algorithms branch from 8f6f95f to 277a5a1 Compare June 4, 2024 09:15
@dsmits dsmits merged commit 628fed1 into main Jun 4, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Auto-generated via {sandpaper}
Source  : 628fed1
Branch  : main
Author  : Djura <djura.smits@gmail.com>
Time    : 2024-06-04 09:16:06 +0000
Message : Merge pull request #13 from vantage6/episode/developing-algorithms

Chapter 7
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Auto-generated via {sandpaper}
Source  : 8367990
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-06-04 09:16:45 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 628fed1
Branch  : main
Author  : Djura <djura.smits@gmail.com>
Time    : 2024-06-04 09:16:06 +0000
Message : Merge pull request #13 from vantage6/episode/developing-algorithms

Chapter 7
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
Auto-generated via {sandpaper}
Source  : 8367990
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-06-04 09:16:45 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 628fed1
Branch  : main
Author  : Djura <djura.smits@gmail.com>
Time    : 2024-06-04 09:16:06 +0000
Message : Merge pull request #13 from vantage6/episode/developing-algorithms

Chapter 7
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
Auto-generated via {sandpaper}
Source  : 8367990
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-06-04 09:16:45 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 628fed1
Branch  : main
Author  : Djura <djura.smits@gmail.com>
Time    : 2024-06-04 09:16:06 +0000
Message : Merge pull request #13 from vantage6/episode/developing-algorithms

Chapter 7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants