Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed image chapter 2 #34

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fixed image chapter 2 #34

merged 1 commit into from
Jun 19, 2024

Conversation

wbaccinelli
Copy link
Contributor

Fixes #23

Copy link

github-actions bot commented Jun 19, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/vantage6/vantage6-workshop/compare/md-outputs..md-outputs-PR-34

The following changes were observed in the rendered markdown documents:

 2-understanding-v6.md | 2 +-
 md5sum.txt            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-06-19 13:36:39 +0000

@wbaccinelli wbaccinelli requested a review from dsmits June 19, 2024 13:36
github-actions bot pushed a commit that referenced this pull request Jun 19, 2024
Copy link
Member

@dsmits dsmits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prachtig

@dsmits dsmits merged commit 09679bc into main Jun 19, 2024
3 checks passed
@dsmits dsmits deleted the fix_image_chapter2 branch June 19, 2024 13:38
github-actions bot pushed a commit that referenced this pull request Jun 19, 2024
Auto-generated via {sandpaper}
Source  : 09679bc
Branch  : main
Author  : Djura <djura.smits@gmail.com>
Time    : 2024-06-19 13:38:49 +0000
Message : Merge pull request #34 from vantage6/fix_image_chapter2

fixed image chapter 2
github-actions bot pushed a commit that referenced this pull request Jun 19, 2024
Auto-generated via {sandpaper}
Source  : 4cbe557
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-06-19 13:39:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 09679bc
Branch  : main
Author  : Djura <djura.smits@gmail.com>
Time    : 2024-06-19 13:38:49 +0000
Message : Merge pull request #34 from vantage6/fix_image_chapter2

fixed image chapter 2
github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
Auto-generated via {sandpaper}
Source  : 4cbe557
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-06-19 13:39:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 09679bc
Branch  : main
Author  : Djura <djura.smits@gmail.com>
Time    : 2024-06-19 13:38:49 +0000
Message : Merge pull request #34 from vantage6/fix_image_chapter2

fixed image chapter 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] First picture is broken in chapter 2 vantage6 basics
2 participants