Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

58 questions and key points need to be added #59

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

dsmits
Copy link
Member

@dsmits dsmits commented Aug 6, 2024

No description provided.

@dsmits dsmits linked an issue Aug 6, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Aug 6, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/vantage6/vantage6-workshop/compare/md-outputs..md-outputs-PR-59

The following changes were observed in the rendered markdown documents:

 chap1_introduction_FL.md | 15 ++++++++++++---
 md5sum.txt               |  2 +-
 2 files changed, 13 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-09-04 14:38:31 +0000

github-actions bot pushed a commit that referenced this pull request Aug 6, 2024
@dsmits dsmits requested a review from wbaccinelli September 4, 2024 13:56
Copy link
Contributor

@wbaccinelli wbaccinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, only really minor suggestions.

dsmits and others added 3 commits September 4, 2024 16:36
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
@dsmits dsmits merged commit 2d698dd into main Sep 4, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
@dsmits dsmits deleted the 58-questions-and-key-points-need-to-be-added branch September 4, 2024 14:39
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
Auto-generated via {sandpaper}
Source  : 2d698dd
Branch  : main
Author  : Djura <djura.smits@gmail.com>
Time    : 2024-09-04 14:39:08 +0000
Message : Merge pull request #59 from vantage6/58-questions-and-key-points-need-to-be-added

58 questions and key points need to be added
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
Auto-generated via {sandpaper}
Source  : 6c75f68
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-09-04 14:39:55 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 2d698dd
Branch  : main
Author  : Djura <djura.smits@gmail.com>
Time    : 2024-09-04 14:39:08 +0000
Message : Merge pull request #59 from vantage6/58-questions-and-key-points-need-to-be-added

58 questions and key points need to be added
github-actions bot pushed a commit that referenced this pull request Sep 5, 2024
Auto-generated via {sandpaper}
Source  : 6c75f68
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-09-04 14:39:55 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 2d698dd
Branch  : main
Author  : Djura <djura.smits@gmail.com>
Time    : 2024-09-04 14:39:08 +0000
Message : Merge pull request #59 from vantage6/58-questions-and-key-points-need-to-be-added

58 questions and key points need to be added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Questions and key points need to be added
2 participants