Update requirements #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbar
commented
Sep 12, 2023
There was a problem hiding this comment.
This is ready too - I'd definitely recommend including this prior to the next release since the scikit-learn pin is so old that it prevents pip from picking up wheels in some cases (e.g. Python 3.10).
FWIW the test suite passes with the removed pins, though there may be other sharp corners that aren't covered by tests. Running through any example notebooks with the proposed dependencies would be a good - any other ideas?
rossbar
force-pushed
the
update-requirements
branch
from
89db1ca to
2f382f2
Compare
|
I will self-merge to improve Python 3.10 support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronize requirements with main deepcell library and rm upper pins where possible.