Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore defaultForCurrency variable in the Card #238

Merged
merged 9 commits into from
Nov 3, 2023

Conversation

Maxim-Inv
Copy link
Contributor

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Andrewangeta
Copy link
Member

@Maxim-Inv Where is this property on the card resource? I'm not seeing it here https://stripe.com/docs/api/cards/object

@Maxim-Inv
Copy link
Contributor Author

@Andrewangeta Oh, really. I still get this field because I haven't upgraded the API version. I'll try to update it now.

@Maxim-Inv
Copy link
Contributor Author

@Andrewangeta I've checked Stripe API version 2023-10-16, the default_for_currency field is present in the response.

  {
      "id": "card_......",
      "object": "card",
      "account": "acct_......",
      "address_city": null,
      "address_country": null,
      "address_line1": null,
      "address_line1_check": null,
      "address_line2": null,
      "address_state": null,
      "address_zip": null,
      "address_zip_check": null,
      "available_payout_methods": [
        "standard",
        "instant"
      ],
      "brand": "MasterCard",
      "country": "US",
      "currency": "usd",
      "cvc_check": "pass",
      "default_for_currency": true,
      "dynamic_last4": null,
      "exp_month": 12,
      "exp_year": 2025,
      "fingerprint": "......",
      "funding": "debit",
      "last4": "0000",
      "metadata": {},
      "name": null,
      "status": "new",
      "tokenization_method": null,
      "wallet": null
    },

@Maxim-Inv
Copy link
Contributor Author

@Maxim-Inv
Copy link
Contributor Author

@Andrewangeta actually, this variable was in the previous versions and I use it in my project. So, it would be great if you accept this PR.

@Andrewangeta Andrewangeta merged commit 23bac40 into vapor-community:main Nov 3, 2023
10 of 12 checks passed
@Maxim-Inv
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants