Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update jenkins to use ci shared pipeline #27

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Conversation

edaniszewski
Copy link
Contributor

This PR:

  • updates CI config to use the ci-shared pipeline

fixes #26

Copy link
Contributor

@MatthewHink MatthewHink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at this one and CI is just running lint and building the docker image. It's not running tests, but it's not clear that there are any tests in this repo.

@edaniszewski
Copy link
Contributor Author

Yeah, thanks for reminding. I was going to open an issue about that and totally spaced. It looks like this repo doesn't have any tests defined, which seems not ideal. Probably low-priority right now since we don't really use this plugin currently, but still something we should have.

@edaniszewski
Copy link
Contributor Author

added #28 to address the lack of tests

@edaniszewski edaniszewski merged commit 9db8231 into master Sep 30, 2020
@edaniszewski edaniszewski deleted the ci/update branch September 30, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update CI to use shared pipeline
2 participants