Skip to content

1.20.0 - Add `shutdownAsync`

Latest
Latest
Compare
Choose a tag to compare
@penny-for-vapor penny-for-vapor released this 31 Jul 16:01
1.20.0
e048c8e
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Learn about vigilant mode.

What's Changed

Add shutdownAsync by @0xTim in #109

Even calling Dispatch’s .wait() can cause the concurrency pool to deadlock meaning the connection pool never returns. This provides a proper async version of shutdown().

Annotates the offending functions with @noasync

See https://swift-open-source.slack.com/archives/C9MMT6VGB/p1722432257179729 for more context

Reviewers

Thanks to the reviewers for their help:

This patch was released by @0xTim

Full Changelog: 1.19.1...1.20.0

Contributors

0xTim and MahdiBM
Assets 2
Loading