Skip to content

fix: ensure FORMAT sample order is in-sync with header sample order (… #1252

fix: ensure FORMAT sample order is in-sync with header sample order (…

fix: ensure FORMAT sample order is in-sync with header sample order (… #1252

GitHub Actions / clippy succeeded Jan 21, 2025 in 0s

clippy

32 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 32
Note 0
Help 0

Versions

  • rustc 1.84.0 (9fc6b4312 2025-01-07)
  • cargo 1.84.0 (66221abde 2024-11-19)
  • clippy 0.1.84 (9fc6b43126 2025-01-07)

Annotations

Check warning on line 37 in src/verify/seqvars.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty line after doc comment

warning: empty line after doc comment
  --> src/verify/seqvars.rs:36:5
   |
36 | /     /// Path to output TSV file.
37 | |
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
   = help: if the empty line is unintentional remove it

Check warning on line 33 in src/verify/seqvars.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty line after doc comment

warning: empty line after doc comment
  --> src/verify/seqvars.rs:32:5
   |
32 | /     /// Path to the reference FASTA file.
33 | |
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
   = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
   = help: if the empty line is unintentional remove it

Check warning on line 1755 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
    --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs:1755:22
     |
1755 |                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
     |                      ^^^                     ^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
1755 -                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
1755 +                 impl serde::de::Visitor<'_> for GeneratedVisitor {
     |

Check warning on line 1637 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
    --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs:1637:14
     |
1637 |         impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
     |              ^^^                     ^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
1637 -         impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
1637 +         impl serde::de::Visitor<'_> for GeneratedVisitor {
     |

Check warning on line 1536 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
    --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs:1536:22
     |
1536 |                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
     |                      ^^^                     ^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
1536 -                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
1536 +                 impl serde::de::Visitor<'_> for GeneratedVisitor {
     |

Check warning on line 1442 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
    --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs:1442:14
     |
1442 |         impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
     |              ^^^                     ^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
1442 -         impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
1442 +         impl serde::de::Visitor<'_> for GeneratedVisitor {
     |

Check warning on line 1266 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
    --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs:1266:22
     |
1266 |                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
     |                      ^^^                     ^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
1266 -                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
1266 +                 impl serde::de::Visitor<'_> for GeneratedVisitor {
     |

Check warning on line 1089 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
    --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs:1089:14
     |
1089 |         impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
     |              ^^^                     ^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
1089 -         impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
1089 +         impl serde::de::Visitor<'_> for GeneratedVisitor {
     |

Check warning on line 964 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
   --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs:964:22
    |
964 |                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
    |                      ^^^                     ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
964 -                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
964 +                 impl serde::de::Visitor<'_> for GeneratedVisitor {
    |

Check warning on line 830 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
   --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs:830:14
    |
830 |         impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
    |              ^^^                     ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
830 -         impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
830 +         impl serde::de::Visitor<'_> for GeneratedVisitor {
    |

Check warning on line 729 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
   --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs:729:22
    |
729 |                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
    |                      ^^^                     ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
729 -                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
729 +                 impl serde::de::Visitor<'_> for GeneratedVisitor {
    |

Check warning on line 627 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
   --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs:627:14
    |
627 |         impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
    |              ^^^                     ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
627 -         impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
627 +         impl serde::de::Visitor<'_> for GeneratedVisitor {
    |

Check warning on line 498 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
   --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs:498:22
    |
498 |                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
    |                      ^^^                     ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
498 -                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
498 +                 impl serde::de::Visitor<'_> for GeneratedVisitor {
    |

Check warning on line 331 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
   --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs:331:22
    |
331 |                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
    |                      ^^^                     ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
331 -                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
331 +                 impl serde::de::Visitor<'_> for GeneratedVisitor {
    |

Check warning on line 158 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
   --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs:158:22
    |
158 |                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
    |                      ^^^                     ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
158 -                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
158 +                 impl serde::de::Visitor<'_> for GeneratedVisitor {
    |

Check warning on line 29 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
  --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.txs.serde.rs:29:14
   |
29 |         impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
   |              ^^^                     ^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
29 -         impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
29 +         impl serde::de::Visitor<'_> for GeneratedVisitor {
   |

Check warning on line 199 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.server.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
   --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.server.serde.rs:199:22
    |
199 |                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
    |                      ^^^                     ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
199 -                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
199 +                 impl serde::de::Visitor<'_> for GeneratedVisitor {
    |

Check warning on line 70 in /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.server.serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'de

warning: the following explicit lifetimes could be elided: 'de
  --> /home/runner/work/mehari/mehari/target/debug/build/mehari-bc7fb2165ed95fcc/out/mehari.server.serde.rs:70:22
   |
70 |                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
   |                      ^^^                     ^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
   |
70 -                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
70 +                 impl serde::de::Visitor<'_> for GeneratedVisitor {
   |

Check warning on line 241 in src/db/subset/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> src/db/subset/mod.rs:241:19
    |
241 |     gene_symbols: &Vec<String>,
    |                   ^^^^^^^^^^^^ help: change this to: `&[String]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

Check warning on line 228 in src/db/subset/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> src/db/subset/mod.rs:228:21
    |
228 |     transcript_ids: &Vec<String>,
    |                     ^^^^^^^^^^^^ help: change this to: `&[String]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
    = note: `#[warn(clippy::ptr_arg)]` on by default

Check warning on line 1322 in src/db/create/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `map_or` is redundant

warning: this `map_or` is redundant
    --> src/db/create/mod.rs:1319:26
     |
1319 |           let seleno_tag = tx
     |  __________________________^
1320 | |             .biotype
1321 | |             .as_ref()
1322 | |             .map_or(false, |bt| bt.contains(&BioType::Selenoprotein))
     | |_____________________________________________________________________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
help: use is_some_and instead
     |
1319 ~         let seleno_tag = tx
1320 +             .biotype
1321 +             .as_ref().is_some_and(|bt| bt.contains(&BioType::Selenoprotein))
     |

Check warning on line 1308 in src/db/create/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `map_or` is redundant

warning: this `map_or` is redundant
    --> src/db/create/mod.rs:1305:15
     |
1305 |               | self
     |  _______________^
1306 | |                 .discards
1307 | |                 .get(&Identifier::Hgnc(*hgnc_id))
1308 | |                 .map_or(false, |reason| !reason.is_empty());
     | |___________________________________________________________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
help: use is_some_and instead
     |
1305 ~             | self
1306 +                 .discards
1307 ~                 .get(&Identifier::Hgnc(*hgnc_id)).is_some_and(|reason| !reason.is_empty());
     |

Check warning on line 1303 in src/db/create/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `map_or` is redundant

warning: this `map_or` is redundant
    --> src/db/create/mod.rs:1303:24
     |
1303 |         let filtered = reason.map_or(false, |reason| !reason.is_empty());
     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_some_and instead: `reason.is_some_and(|reason| !reason.is_empty())`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or

Check warning on line 1256 in src/db/create/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `map_or` is redundant

warning: this `map_or` is redundant
    --> src/db/create/mod.rs:1256:32
     |
1256 |                 let filtered = hgnc_reason.map_or(false, |reason| !reason.is_empty());
     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_some_and instead: `hgnc_reason.is_some_and(|reason| !reason.is_empty())`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or

Check warning on line 801 in src/db/create/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `map_or` is redundant

warning: this `map_or` is redundant
   --> src/db/create/mod.rs:798:16
    |
798 |               if gene
    |  ________________^
799 | |                 .biotype
800 | |                 .as_ref()
801 | |                 .map_or(false, |bt| bt.contains(&BioType::Pseudogene))
    | |______________________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
help: use is_some_and instead
    |
798 ~             if gene
799 +                 .biotype
800 +                 .as_ref().is_some_and(|bt| bt.contains(&BioType::Pseudogene))
    |