-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump dependencies #226
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -29,14 +29,9 @@ | |||||||||||||||
tracing::info!("args_common = {:?}", &args_common); | ||||||||||||||||
tracing::info!("args = {:?}", &args); | ||||||||||||||||
|
||||||||||||||||
if let Some(level) = args_common.verbose.log_level() { | ||||||||||||||||
match level { | ||||||||||||||||
log::Level::Trace | log::Level::Debug => { | ||||||||||||||||
std::env::set_var("RUST_LOG", "debug"); | ||||||||||||||||
env_logger::init_from_env(env_logger::Env::new().default_filter_or("info")); | ||||||||||||||||
} | ||||||||||||||||
_ => (), | ||||||||||||||||
} | ||||||||||||||||
if let Some(log::Level::Trace | log::Level::Debug) = args_common.verbose.log_level() { | ||||||||||||||||
std::env::set_var("RUST_LOG", "debug"); | ||||||||||||||||
env_logger::init_from_env(env_logger::Env::new().default_filter_or("info")); | ||||||||||||||||
Comment on lines
+32
to
+34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Consider revising the logging configuration approach The current implementation has potential issues:
Consider this more idiomatic approach: - if let Some(log::Level::Trace | log::Level::Debug) = args_common.verbose.log_level() {
- std::env::set_var("RUST_LOG", "debug");
- env_logger::init_from_env(env_logger::Env::new().default_filter_or("info"));
+ if let Some(level) = args_common.verbose.log_level() {
+ env_logger::Builder::new()
+ .filter_level(level.to_level_filter())
+ .init(); This approach:
📝 Committable suggestion
Suggested change
|
||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
tracing::info!("Loading HPO..."); | ||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify tempdir version change
The tempdir version change from 0.3.7 to 0.3 appears to be a downgrade. Please verify if this is intentional or if it should be 0.3.x where x ≥ 7.