Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proper OpenAPI-documented and versioned endpoints (#227) #228

Merged

Conversation

holtgrewe
Copy link
Collaborator

@holtgrewe holtgrewe commented Nov 20, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Updated API endpoints to version 1, enhancing clarity with paths like /api/v1/hpo/....
    • Introduced structured error handling with standardized responses for error codes.
  • Improvements

    • Enhanced response schemas for better specificity in API results.
    • Renamed and restructured query and result data types for improved clarity and maintainability.
  • Bug Fixes

    • Resolved inconsistencies in naming conventions across various API endpoints.
  • Documentation

    • Updated OpenAPI documentation to reflect new naming conventions and improved error handling structures.

@holtgrewe holtgrewe linked an issue Nov 20, 2024 that may be closed by this pull request
Copy link

coderabbitai bot commented Nov 20, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant modifications to the API structure, primarily updating endpoint paths to include versioning (e.g., from /hpo/... to /api/v1/hpo/...). It also involves renaming several data structures for clarity, enhancing error handling with new response schemas, and updating operation IDs to camel case. Additionally, various new schemas have been added to improve the definition of queries and results. The changes aim to refine the API's organization and usability without altering its core functionality.

Changes

File Change Summary
openapi.yaml Updated API paths to include versioning, modified operation IDs to camel case, added new error handling responses, and introduced new schemas for queries/results.
src/query/mod.rs Renamed structs for clarity: Query to HpoSimTermGeneQuery, Result to HpoSimTermGeneResult, and updated internal logic accordingly.
src/server/run/hpo_genes.rs Renamed structs to HpoGenesQuery, HpoGenesResult, and updated function signatures to reflect new types, along with API path changes.
src/server/run/hpo_omims.rs Renamed structs to HpoOmimsQuery, HpoOmimsResult, and updated function signatures, including changes to the API path.
src/server/run/hpo_sim/term_gene.rs Renamed Query to HpoSimTermGeneQuery, updated return types in function signatures, and modified API path to include versioning.
src/server/run/hpo_sim/term_term.rs Renamed ResponseQuery to HpoSimTermTermQuery, updated return types, and modified API path to include versioning.
src/server/run/hpo_terms.rs Renamed Query to HpoTermsQuery, updated return types in function signatures, and modified API path to include versioning.
src/server/run/mod.rs Updated CustomError struct, modified error handling, and refined OpenAPI schema definitions for consistency across various modules.

Possibly related PRs

  • chore: bump dependencies #226: The changes in the main PR involve updates to the API paths and response schemas, which are relevant to the dependency updates in the hpo package noted in this PR.

🐇 In the garden, where changes bloom,
API paths now find more room.
With errors caught in a gentle net,
Clarity grows, no need to fret.
HPO queries dance in new attire,
Versioned and bright, they inspire! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@holtgrewe holtgrewe enabled auto-merge (squash) November 20, 2024 12:45
@holtgrewe holtgrewe merged commit b548942 into main Nov 20, 2024
7 of 8 checks passed
@holtgrewe holtgrewe deleted the 227-provide-proper-openapi-documented-and-versioned-endpoints branch November 20, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide proper OpenAPI-documented and versioned endpoints
1 participant