expire: New MAIN.n_superseded counter #4045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigoroll
reviewed
Jan 30, 2024
There was a problem hiding this comment.
On the bikeshed, I really think superseded is better: If my understanding of the English language is adequate, it makes clear that a specific object is replaced by something which makes the previous object redundant.
Replaced is too general, in my mind: Cache objects can be LRU-replaced by whatever
include/tbl/vsl_tags.h
Outdated
| @@ -360,6 +360,8 @@ SLTM(ExpKill, 0, "Object expiry event", | |||
| "\tLogged when the expiry thread expires an object.\n\n" | |||
| "EXP_Removed\n" | |||
| "\tLogged when the expiry thread removes an object before expiry.\n\n" | |||
| "VBF_Replace\n" | |||
There was a problem hiding this comment.
VBF_Superseded for consistency? (also mentioned by phk)
|
👍 but I really think it should be superseded, not "replaced". |
|
Bugwash: OK. I will apply @nigoroll's suggestions and merge. |
|
Rebased against master, to be merged once CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a case where a user was refining their cache policy and this turned out to be a blind spot.